From 31b393af5789d2daf3d6a3793a83d37656b188ab Mon Sep 17 00:00:00 2001
From: Someone <someone@somenet.org>
Date: Tue, 31 Jan 2023 23:47:04 +0100
Subject: [PATCH] modules/DialogManagedCourseFeedback.py

---
 modules/DialogManagedCourseFeedback.py | 36 +++++++++++++-------------
 1 file changed, 18 insertions(+), 18 deletions(-)

diff --git a/modules/DialogManagedCourseFeedback.py b/modules/DialogManagedCourseFeedback.py
index 457e3e3..f0b70f1 100644
--- a/modules/DialogManagedCourseFeedback.py
+++ b/modules/DialogManagedCourseFeedback.py
@@ -71,8 +71,8 @@ class DialogManagedCourseFeedback(AbstractCommand):
             request.respond(200, {"errors": {"feedback_hours": "Hours must be positive."}})
             return
 
-        if data["submission"]["feedback_hours"] and int(data["submission"]["feedback_hours"]) > 4464:
-            request.respond(200, {"errors": {"feedback_hours": "Hours must be smaller than 4465. Did you really spend EVERY HOUR of the semester for this course? Did you not sleep at all?"}})
+        if data["submission"]["feedback_hours"] and int(data["submission"]["feedback_hours"]) > 3624:
+            request.respond(200, {"errors": {"feedback_hours": "Hours must be smaller than 3624. Did you really spend EVERY HOUR of the semester for this course? Did you not sleep at all?"}})
             return
 
 
@@ -103,14 +103,6 @@ class DialogManagedCourseFeedback(AbstractCommand):
             "title": "Course feedback",
             "submit_label":"Submit",
             "elements":[{
-                "display_name": "Was there an online option? Was it announced? Was it possible to complete the course only online? (Max. 3000 characters)",
-                "placeholder": "Type here. Max. 3000 characters.\n+ What did you think about the online option?\n+ Was it announced?\n+ Was it possible to complete the course only online?",
-                "name": "feedback_distance",
-                "type": "textarea",
-                "help_text": "All your imput on all questions will be anonymized during aggregation. Aggregated input will be analyzed by FSInf and further used/forwarded to the course admins, the deans of study affairs, the vice rector for teaching and possibly others that are deemed able to fix things. You can edit/clear it at any time.",
-                "optional": True,
-                "default": feedback_distance
-            },{
                 "display_name": "How many hours did you invest into this course?",
                 "placeholder": "Hours. Positive integer.",
                 "name": "feedback_hours",
@@ -118,13 +110,6 @@ class DialogManagedCourseFeedback(AbstractCommand):
                 "subtype": "number",
                 "optional": True,
                 "default": feedback_hours
-            },{
-                "display_name": "Describe the modalities (issues encountered and possible improvements) in a few words (Max. 3000 characters)",
-                "placeholder": "Type here. Max. 3000 characters.\n+ What was it? \n+ Were deadlines announced in a timely manner?\n+ Was the grading surprising?\n+ Random changes during the semester?",
-                "name": "feedback_modus",
-                "type": "textarea",
-                "optional": True,
-                "default": feedback_modus
             },{
                 "display_name": "How did you like the modalities of this course? (Do you want it to be applied to others?)",
                 "placeholder": "Type here. Max. 3000 characters.",
@@ -140,7 +125,22 @@ class DialogManagedCourseFeedback(AbstractCommand):
                 "optional": True,
                 "default": feedback_modus_like
             },{
-                "display_name": "Other comment/feedback about the course (Max. 3000 characters)",
+                "display_name": "Describe the modalities (issues encountered and possible improvements) in a few words (Max. 3000 characters)",
+                "placeholder": "Type here. Max. 3000 characters.\n+ What was it? \n+ Were deadlines announced in a timely manner?\n+ Was the grading surprising?\n+ Random changes during the semester?",
+                "name": "feedback_modus",
+                "type": "textarea",
+                "optional": True,
+                "default": feedback_modus
+            },{
+                "display_name": "Was there an online option? Was it announced? Was it possible to complete the course only online? (Max. 3000 characters)",
+                "placeholder": "Type here. Max. 3000 characters.\n+ What did you think about the online option?\n+ Was it announced?\n+ Was it possible to complete the course only online?",
+                "name": "feedback_distance",
+                "type": "textarea",
+                "help_text": "All your imput on all questions will be anonymized during aggregation. Aggregated input will be analyzed by FSInf and further used/forwarded to the course admins, the deans of study affairs, the vice rector for teaching and possibly others that are deemed able to fix things. You can edit/clear it at any time.",
+                "optional": True,
+                "default": feedback_distance
+            },{
+                "display_name": "Overall feedback about the course (Max. 3000 characters)",
                 "placeholder": "Type here. Max. 3000 characters.\n+ What should be changed?\n+ What was unfair?\n+ What was really good?",
                 "name": "feedback_course",
                 "type": "textarea",
-- 
2.43.0