From 16113ba91fcd7c816ad2a49da0c7183afd9a9cbd Mon Sep 17 00:00:00 2001
From: Fabian Eichhorner <fabian.eichhorner@gmail.com>
Date: Sat, 3 Nov 2018 23:54:56 +0100
Subject: [PATCH] fix dockerfile naming and update readme

---
 service-reporting/DOCKERFILE | 35 -----------------------------------
 service-reporting/readme.md  | 10 ++++++----
 2 files changed, 6 insertions(+), 39 deletions(-)
 delete mode 100644 service-reporting/DOCKERFILE

diff --git a/service-reporting/DOCKERFILE b/service-reporting/DOCKERFILE
deleted file mode 100644
index c372a86..0000000
--- a/service-reporting/DOCKERFILE
+++ /dev/null
@@ -1,35 +0,0 @@
-FROM microsoft/dotnet:2.2.100-preview3-sdk AS build-env
-WORKDIR /app
-
-# Copy csproj and restore as distinct layers
-COPY *.csproj ./
-RUN dotnet restore
-
-# Copy everything else and build
-COPY . ./
-RUN dotnet publish -c Release -o out
-
-# Build runtime image
-FROM microsoft/dotnet:2.2.0-preview3-aspnetcore-runtime
-WORKDIR /app
-COPY --from=build-env /app/out .
-
-# copy pdf library
-# COPY libwkhtmltox.* ./
-# install additional libaries
-RUN apt-get update \
-    && apt-get install -y --no-install-recommends \
-        zlib1g \
-        fontconfig \
-        libfreetype6 \
-        libx11-6 \
-        libxext6 \
-        libxrender1 \
-    && curl -o /usr/lib/libwkhtmltox.so \
-        --location \
-        https://github.com/rdvojmoc/DinkToPdf/raw/v1.0.8/v0.12.4/64%20bit/libwkhtmltox.so
-
-		
-# copy assets
-COPY assets/*.css ./assets/		
-ENTRYPOINT ["dotnet", "PdfService.dll"]
\ No newline at end of file
diff --git a/service-reporting/readme.md b/service-reporting/readme.md
index 03be834..ef8b8a2 100644
--- a/service-reporting/readme.md
+++ b/service-reporting/readme.md
@@ -1,15 +1,17 @@
 # PDF Service
 
-Provides an API interface to generate PDF reports for given tweets and their sentiment analysis result.  
+Provides an API interface to generate PDF reports for tweets and their sentiment analysis results. The service uses an .NET Core wrapper for the wkhtmltopdf library to generate pdf out of html code.
+
 `GET`: `/` Shows a demo page  
 - param: none
-- return: pdf file  
-`POST`: `/generatePDF/` Generates a pdf report for the given tweets and sentiments  
+- return: pdf file
+
+`POST`: `/generatePDF/` Generates a pdf report for the given tweets
 - param: Tweet[] as Content-Type: `application/json`  
 - return: pdf file
 
 ### Tweet model
-Tweet(string Name, string Sentiment)
+Tweet(string `Name`, string `Sentiment`)
 
 ## run with docker
 
-- 
2.43.0